Add rig.simple, for breaks on single element #2
Conversation
|
@paulyoung Perhaps it should be called rig.single instead, as that is the main simplification here? |
|
This couples image size to breakpoint size which is something I was trying to avoid. It makes sense to do that for a full-screen background image but in a lot of cases we're displaying an image at a fraction of the screen width. |
|
At first glance I'm a bit confused as to how assigning something to I was anticipating the need to change the API slightly - perhaps making a CoffeeScript class called |
| if not dimension | ||
| dimension = 'width' | ||
| if not breaks | ||
| breaks = [ 400, 800, 1600 ] |
There was a problem hiding this comment.
My preference would be to omit default values and encourage usage to be very intentional, especially the breakpoints which are arbitrary.
For common use cases I'd rather pass these as params inside of a dedicated method. Something like:
Rig.resize = (block, config, selector, breakpoints, sizes) ->
return Rig.simple block, config, selector, 'passthrough', {}, breakpoints, sizesThere was a problem hiding this comment.
or rather, something like:
Rig.resize = (block, config, options) ->
return Rig.simple block, config, 'passthrough', {}, options
Rig.resize block, config,
selector: '#media'
breakpoints: [504, 1008]
widths: [200, 400, 800]
|
Closing this in favor of 9571e0f. |
Fixes #1